Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes are for the addition of the Subtropical to Subpolar North Atlantic Ocean Diagnostics (natl_ocean) POD into the MDTF-diagnostics. The natl_ocean POD is still under development and only contains water mass transformation as its diagnostic at the moment. Because the POD is still under development the checklist isn't going to be completed.
For the natl_ocean POD to run, ocean variables (TAREA, SALT, SHF, SFWF) were added to the fieldlist_NCAR. For this first draft, we used our own model input data (a CESM historical run) but plan to switch to the MDTF provided time series runs.
"TAREA": {
"standard_name": "area of T cells",
"modifier": "ocean_realm",
"units": "centimeters^2",
"ndim": 2
},
"SALT": {
"standard_name": "Salinity",
"units": "psu",
"ndim": 4
"SHF": {
"standard_name": "Surface Heat Flux",
"units": "watts m^-2",
"ndim": 3
},
"SFWF": {
"standard_name": "Surface Freshwater Flux",
"units": "kg/m2/s",
"ndim": 3
We tried to add nlat and nlon to the feildlist because but the MDTF framework is not set up to work with this dimensions so those are hard coded into the POD for the moment. We will need i, j dimensions for 2-d coordinate LAT/LON added to the MDTF software, but need help to get that addition correct.
The POD was added to the diagnostics directory and is located at:
diagnostics/natl_ocean
The POD includes
doc/wmt_dummy.rst - this file hasn't yet been filled out or modified for our specific POD
my_tests.jsonc - this was created so that we could avoid changing default_tests.jsonc
natl_ocean.html - this file has been changed slightly to align with our POD
natl_wmt.py - contains the code to calculate water mass transformation
natl_ocean.py - the driver script that calls natl_wmt.py, for testing purposes this script also includes calculating the time means of variables that are used in the POD
settings.jsonc - changed to work with the POD
Below is a sample plot of the wmt diagnostic
How Has This Been Tested?
The POD was run on a Linux system using python version 3.10 using the default MDTF env and the expected wallclock time is <1 minute
Checklist:
conda_env_setup.sh